Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from IntKey to new naked int key #549

Closed
ueco-jb opened this issue Nov 15, 2021 · 0 comments · Fixed by #564
Closed

Migrate from IntKey to new naked int key #549

ueco-jb opened this issue Nov 15, 2021 · 0 comments · Fixed by #564
Assignees
@ueco-jb
Labels
storage plus
Projects
Contract development
Milestone
v0.11.0

Comments

@ueco-jb
Copy link
Collaborator

ueco-jb commented Nov 15, 2021 •
edited by maurolacy

Follow up of #472.

Since new Key wrapper type was added in #547, now it's time to start actually deprecating IntKey type usage.
Change default prefix's type from IntKey to Key a naked int key in some contract as an example.
Tests in, for example, map.rs from storage-plus could be adapted as well:
https://github.com/CosmWasm/cw-plus/blob/main/packages/storage-plus/src/map.rs#L272

Example in contract: https://github.com/CosmWasm/cw-plus/blob/main/contracts/cw3-flex-multisig/src/state.rs#L156-L157
@ueco-jb ueco-jb added this to To do in Contract development via automation Nov 15, 2021
@ueco-jb ueco-jb added this to the v0.11.0 milestone Nov 15, 2021
@ueco-jb ueco-jb mentioned this issue Nov 15, 2021
Closed
@ueco-jb ueco-jb self-assigned this Nov 30, 2021
@ueco-jb ueco-jb moved this from To do to In progress in Contract development Nov 30, 2021
@ueco-jb ueco-jb changed the title Migrate from IntKey to new Key type Migrate from IntKey to new naked int key Nov 30, 2021
@ueco-jb ueco-jb mentioned this issue Nov 30, 2021
Merged
@ueco-jb ueco-jb moved this from In progress to Review in progress in Contract development Nov 30, 2021
Contract development automation moved this from Review in progress to Done Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ueco-jb ueco-jb

Labels
storage plus
Projects
No open projects
Contract development
  
Done
Milestone
v0.11.0
Development

Successfully merging a pull request may close this issue.

Migrate from IntKey to new naked int key CosmWasm/cw-plus
1 participant
@ueco-jb