Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base-helpers.ts doesn't belong to contracts #566

Closed
hashedone opened this issue Dec 2, 2021 · 4 comments · Fixed by #574
Closed

base-helpers.ts doesn't belong to contracts #566

hashedone opened this issue Dec 2, 2021 · 4 comments · Fixed by #574

Comments

@hashedone
Copy link
Contributor

hashedone commented Dec 2, 2021

contracts structure is assumed by the wasm workspace building utility. Because of base-helpers.ts file it is now impossible to easly build workspace with it. (it is actually working with newest version, but it still doesn't belong here prob). Either this file should move to some better place (some utilities? it is not a contract so it doesn't belong there semantically) or workspace builder should be altered to better detect what to build.

@ethanfrey
Copy link
Member

ethanfrey commented Dec 6, 2021

I proposed a new repo for this. I will follow up with @orkunkl on this one.

Let's move all the ts helpers to a repo with a proper npm package and build system (so we can use typescript) and a CI to test they work against these contracts. They can be pushed to npm and people can just import these.

I know Orkun has some larger ideas of a framework, but I think it would be very useful to move them out of this repo in the short term, so they can be properly tested and maintained. Okrun, please let me know what you need to do so.

@orkunkl
Copy link
Contributor

orkunkl commented Dec 9, 2021

For temporary, we can setup an InterWasm/cw-plus-helpers repo to contain these helpers @findolor

@orkunkl
Copy link
Contributor

orkunkl commented Dec 9, 2021

Will be moved to https://github.com/InterWasm/cw-plus-helpers

@ethanfrey
Copy link
Member

Thanks Orkun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants