Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MultiIndex last type param default / docs #669

Closed
maurolacy opened this issue Feb 22, 2022 · 0 comments · Fixed by #671
Closed

Fix MultiIndex last type param default / docs #669

maurolacy opened this issue Feb 22, 2022 · 0 comments · Fixed by #671
Assignees
Labels
breaking Breaking changes storage plus

Comments

@maurolacy
Copy link
Contributor

maurolacy commented Feb 22, 2022

With the latest implementation of type-safe bounds, the definition of a MultiIndex PK type is crucial, as it now serves to define the type of the (partial) bounds over the index key (the part that corresponds to the pk, that is). See https://github.com/confio/poe-contracts/pull/114/files#r812029191 for reference / an example.

Let's fix the docs to reflect this use case, and its importance.

Also, let's remove the default over PK that we introduced for backwards compatibility, as this type definition is now really important for specifying (type-safe) bounds.

@ueco-jb ueco-jb changed the title [cw-storage-plus] Fix MulttiIndex last type param docs Fix MultiIndex last type param docs Feb 22, 2022
@maurolacy maurolacy self-assigned this Feb 22, 2022
@maurolacy maurolacy changed the title Fix MultiIndex last type param docs Fix MultiIndex last type param default / docs Feb 23, 2022
@maurolacy maurolacy added the breaking Breaking changes label Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes storage plus
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants