Out of gas handling #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reuvenpo
force-pushed
the
out-of-gas-handling
branch
from
63ad440
to
107ca11
Compare
|
Doesn't this resolve #73 as well? Or at least a big part of it? |
To a large extent, yeah, but not fully, yet. I can mark it as related since to get all the information across from the Go callback to the Go caller, it needs to basically be fixed as well. |
reuvenpo
commented
May 15, 2020
reuvenpo
force-pushed
the
out-of-gas-handling
branch
from
269fddf
to
2bfde32
Compare
2 tasks
| GoResult::Panic => Err(make_ffi_foreign_panic()), | ||
| GoResult::BadArgument => Err(make_ffi_bad_argument()), | ||
| GoResult::OutOfGas => Err(make_ffi_out_of_gas()), | ||
| GoResult::Other => Err(make_ffi_other("Unspecified error in Go code")), |
There was a problem hiding this comment.
okay, so this is the reason we need error mutability: we only get the i32 from Go.
There was a problem hiding this comment.
no and yes.
we get it from go, but we also create the FfiError in go-cosmwasm, so we can have a method on GoResult that converts the GoResult to an FfiError, but also takes an Into<String> which is only used if it's Other
webmaster128
approved these changes
May 18, 2020
faddat
pushed a commit
to faddat/go-cosmwasm
that referenced
this pull request
Dec 10, 2021
Add labels to contract instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #29 and fix #79.
It depends on CosmWasm/cosmwasm#331