Skip to content
This repository has been archived by the owner on Nov 5, 2023. It is now read-only.

Feature: Add unranked variants for functions that take ranking_func #34

Closed
1 of 3 tasks
CosmicHorrorDev opened this issue May 4, 2020 · 2 comments
Closed
1 of 3 tasks
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@CosmicHorrorDev
Copy link
Owner

Feature Request

  • Expose functionality from the API
  • Add extra functionality in the library
  • Other:

Description

Some people may want the option to directly get all the results returned by the SearchSubtitles and GuessMovieFromString endpoints instead of trying to have the results limited to a single value by asw.search_subtiltes(...) and asw.guess_media(...). This can easily be done by having an alternate function that orders the results to match the provided queries and returns the results without any ranking. To prevent duplicate code the ranked variant can just use the unranked functions under the hood before applying the ranking_func.

@CosmicHorrorDev
Copy link
Owner Author

Implementation added, but still needs documentation

@CosmicHorrorDev
Copy link
Owner Author

Docs updated in 2fcee68.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant