Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextView with animated placeholder #1125

Closed
kolczak opened this issue Aug 1, 2018 · 3 comments
Closed

TextView with animated placeholder #1125

kolczak opened this issue Aug 1, 2018 · 3 comments
Assignees
@OrkhanAlikhanov
Labels
enhancement feature request material

Comments

@kolczak
Copy link

kolczak commented Aug 1, 2018 •
edited
Loading

Hi,
are you considering implementing a TextView with same placeholder behavior as TextField? It looks a bit odd when I place TextField and TextView below that.
BTW: Great job implementing that lib.
Regards!
@daniel-jonathan
Copy link
Member

Thank you! @OrkhanAlikhanov is working on it at the moment. I would say a PR would be ready within the next couple days.

@kolczak
Copy link
Author

kolczak commented Aug 2, 2018

Great! I also started working on it, but now I will stop and wait for your PR. Additionally what I noticed comparing it to TextField is that divider is not animated (doesn't have different colors on active and normal states).

@OrkhanAlikhanov OrkhanAlikhanov mentioned this issue Aug 7, 2018
Merged
@daniel-jonathan
Copy link
Member

This feature has been addressed in this PR #1130

@daniel-jonathan daniel-jonathan mentioned this issue Mar 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OrkhanAlikhanov OrkhanAlikhanov

Labels
enhancement feature request material
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kolczak @daniel-jonathan @OrkhanAlikhanov