Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CocoaPods] MaterialIcon not displaying #279

Closed
gilthonweapps opened this issue Apr 1, 2016 · 3 comments
Closed

[CocoaPods] MaterialIcon not displaying #279

gilthonweapps opened this issue Apr 1, 2016 · 3 comments
Assignees
@daniel-jonathan
Labels
enhancement question

Comments

@gilthonweapps
Copy link

Hi,

If you install Material with cocoapods, the icons from MaterialIcon (e.g. MaterialIcon.close) always return nil.

I submitted a PR a while ago that was fixing this issue, but I saw that you recently put back your old code...
@daniel-jonathan daniel-jonathan self-assigned this Apr 1, 2016
@daniel-jonathan
Copy link
Member

Hey,

When I tried your solution in an app without CocoaPods it broke and could not find the bundle. We would need to think of another solution.

@daniel-jonathan
Copy link
Member

I would like to solve this issue. So I am going to leave this up and we can work on it, or I will update you when I have come to a resolution. I will aim for this weekend to have a solution.

@daniel-jonathan
Copy link
Member

This has been resolved in 1.38.5. The fix is to check if the bundle can be found using the CocoaPods approach, and if not, use the default bundle location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-jonathan daniel-jonathan

Labels
enhancement question
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gilthonweapps @daniel-jonathan