Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid System dose not work #613

Closed
yunhao opened this issue Nov 28, 2016 · 6 comments
Closed

Grid System dose not work #613

yunhao opened this issue Nov 28, 2016 · 6 comments

Comments

@yunhao
Copy link

yunhao commented Nov 28, 2016

Material 2.3.19
Xcode8

I tried to follow the tutorials in http://www.cosmicmind.com/material/grid

class ViewController: UIViewController {

    override func viewDidLoad() {
        super.viewDidLoad()
        
        let container = View()
        container.shapePreset = .square
        container.grid.interimSpacePreset = .interimSpace3
        
        view.layout(container).top(100).left(20).right(20)
        
        for _ in 0..<12 {
            let v = View()
            v.grid.columns = 1
            v.backgroundColor = Color.blue.base
            container.grid.views.append(v)
        }

    }

}

But only a blank page was showed on my screen. I saw this in Xcode8 by UI View Hierarchy:
image

It seems that the layout is broken.

@daniel-jonathan
Copy link
Member

Yes, there is an issue. I am pushing a fix within the hour. Thank you!

@daniel-jonathan
Copy link
Member

daniel-jonathan commented Nov 28, 2016

Please update to Material 2.3.20, where you can find a fix for this issue. :) Thanks

You can find a sample project at Grid Sample.

@samma89
Copy link

samma89 commented Aug 27, 2019

Hi,

It seems this issue is there in 3.1.6 release.
I am running your sample grid from Samples repo.

Screen Shot 2019-08-27 at 7 25 21 AM

Any idea of why?

Thanks

@daniel-jonathan
Copy link
Member

@samma89 We are updating the samples next week. We haven't had a chance to do so, because of a new product we are launching internally for testing this week, and announced next week. Sorry for any delays. We will look into this.

@samma89
Copy link

samma89 commented Aug 29, 2019

@DanielDahan Thank you!

@daniel-jonathan
Copy link
Member

daniel-jonathan commented Sep 11, 2019

Hi there, sorry for any delays. We discovered that some earlier updates had caused a regression. You can find a fix in Material 3.1.7. Please test, and if there is still an issue, please reopen this issue or create a new issue. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants