Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding another type of PulseView animation #641

Closed
jyounus opened this issue Dec 20, 2016 · 6 comments
Closed

Adding another type of PulseView animation #641

jyounus opened this issue Dec 20, 2016 · 6 comments

Comments

@jyounus
Copy link

jyounus commented Dec 20, 2016

Hey there,

Any chance you'd consider adding a "new" type of animation? Basically I'd like the PulseView to have the same effect as if it was a standard iOS UITableViewCell highlight. This means it would instantly highlight the view when the user touches it, and then deselect with an animation.

It's pretty much exactly the same as the pulseAnimation = .backing animation, the only difference is it wouldn't delay the fade in. It would instantly highlight and then fade out using an animation once the user stops touching the view.

I know this doesn't have much to do with Material Design and rather a more iOS-y animation, but this would be perfect for my existing project.

@daniel-jonathan
Copy link
Member

Doesn't sound like a bad suggestion to me :) It will be out by the end of the month, along with all the other latest features.

@daniel-jonathan
Copy link
Member

Adding this for release Material 2.5.0.

@jyounus
Copy link
Author

jyounus commented Dec 25, 2016

Nice one, thank you! I'll go ahead and close this "issue". :D

@jyounus jyounus closed this as completed Dec 25, 2016
@daniel-jonathan
Copy link
Member

daniel-jonathan commented Dec 29, 2016

Hey, here is the commit for your feature request. It will be out shortly in Material 2.5.0 :) Currently the new animation is called tap and is set like so, pulseView.pulseAnimation = .tap.

@jyounus
Copy link
Author

jyounus commented Dec 29, 2016

Gave it a quick try, just what I wanted! Thank you!

@daniel-jonathan
Copy link
Member

Sweet :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants