Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View blinks when popping view controller on UINavigationController #17

Closed
ghks1353 opened this issue Nov 14, 2017 · 5 comments
Closed

Comments

@ghks1353
Copy link

ghks1353 commented Nov 14, 2017

First of all, sorry for my bad English.

I'm using Motion on my project in UINavigationController, view blinks with black color when pushing/pop view controller repeatedly after 10 times.

First 10 times of translation is OK and no glitches, but it blinks weirdly by repeating popping vieewcontroller a few times after.
Additional: And some subview blinks when pushing view controller after pushing 10 times.

I just enabled isMotionEnabled property on my UINavController and UIViewController.
Here is my view controller code for setup Motion:

self.isMotionEnabled = true
self.navigationController?.motionNavigationTransitionType = .autoReverse(presenting: .fade)
current.motionIdentifier = "ppj-header-progress"

I tried to remove motionNavigationTransitionType but same result.

Update: This issuse is caused on iPhone X, iOS 11.1.1
Update 2: My code works perfectly and not happening any issue on iPhone 4s, iOS 9
Update 3: Not happening black blink issue on iPhone 5s, iOS 11 but some subviews translates weirdly (e.g. blinking layer shadows) when pushing/popping view.

ezgif com-optimize

@daniel-jonathan daniel-jonathan self-assigned this Nov 14, 2017
@daniel-jonathan
Copy link
Member

Nice find. Can you send over the sample project you are using so I can easily reproduce this? As well, is this only happening in the simulator?

@ghks1353
Copy link
Author

I attached sample project archive. You can see screen is blink weirdly after pushing viewcontrollers a few times after, also you can see blinking navigation bar on the top when pushing vc every time.
I added some views (like UIImageView) in my sample and it also blinking weirdly.

I tested on my real device of iPhone X, iPhone 4s and iPhone 5s, not simulator.
Simulator works fine and no glitches on my iPhone X simulator.

sample.zip

@daniel-jonathan
Copy link
Member

Thank you! I am going to test this today.

@daniel-jonathan
Copy link
Member

Looking at this now. Thank you!

@daniel-jonathan
Copy link
Member

Please give Motion 1.3.0 a try. If the issue persists, please reopen it. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants