Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbalanced calls to begin/end appearance #29

Closed
joergbirkhold opened this issue Feb 26, 2018 · 8 comments
Closed

Unbalanced calls to begin/end appearance #29

joergbirkhold opened this issue Feb 26, 2018 · 8 comments
Assignees

Comments

@joergbirkhold
Copy link

I got this message when presenting this Navigationcontroller.
"Unbalanced calls to begin/end appearance"
(The animation works as expected)

class AnimatableNavController: UINavigationController {

    var transtype:MotionTransitionAnimationType?
    
    open override func viewDidLoad() {
        super.viewDidLoad()
        isMotionEnabled = true
        motionTransitionType = transtype ?? .push(direction: .right)
        motionNavigationTransitionType = transtype ?? .push(direction: .right)
    }
}
@daniel-jonathan
Copy link
Member

Hey! I am sorry it took so long to get back to you. I don't recall seeing this. Please, if you still have any issues, let me know. Thank you!

@StepanetsDmtry
Copy link

So this bug is still present. For example, I have NavigationDrawer controller with ToolBarController as root view controller. Then I try to present modally SearchBarController, motion animation worked perfectly

let searchController = AppStoryboard.Tree.viewController(viewControllerClass: SearchViewController.self)
let searchBarController = SearchBarController(rootViewController: searchController)
searchBarController.isMotionEnabled = true
searchBarController.motionTransitionType = .autoReverse(presenting: .fade)
toolbarController?.present(searchBarController, animated: true)

But in log I see messages:

Unbalanced calls to begin/end appearance transitions for <Material.SearchBarController: 0x7f8db554bde0>.
Unbalanced calls to begin/end appearance transitions for <NavigationDrawerController: 0x7f8db680b000>.

@joergbirkhold
Copy link
Author

Sorry for the delay too, but I also still see this.

@daniel-jonathan
Copy link
Member

I will see if I can replicate this issue. If you have a sample project that replicates this 100% of the time, I would appreciate it. Thank you for sharing the issue.

@StepanetsDmtry
Copy link

Hello @DanielDahan thank you for your fast reply. I have attached a sample project.

SampleMotion.zip

In this project current issue representing in 100% of the time.

@daniel-jonathan
Copy link
Member

@OrkhanAlikhanov Let's take a look at this.

@daniel-jonathan
Copy link
Member

daniel-jonathan commented Jul 19, 2018

This is now fixed in Motion 1.4.3. Thank you!

@StepanetsDmtry
Copy link

Thank you too! Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants