Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TabsController - iPhoneX #78

Closed
MattKiazyk opened this issue Oct 26, 2017 · 2 comments
Closed

TabsController - iPhoneX #78

MattKiazyk opened this issue Oct 26, 2017 · 2 comments
Assignees
@daniel-jonathan
Labels
bug

Comments

@MattKiazyk
Copy link

Currently the TabsController example doesn't handle the iPhoneX safeAreaLayout changes.

screenshot 2017-10-26 15 08 54

In iPhoneX scenario, the tab bar should be in the safe area, with the height stretched into the unsafe area.

The BottomNavigationController example is a good one that when using UITabBar it resizes properly.

screenshot 2017-10-26 15 13 20

Thanks!
@daniel-jonathan daniel-jonathan self-assigned this Oct 26, 2017
@daniel-jonathan
Copy link
Member

A great, thank you! I will add this fix.

@daniel-jonathan
Copy link
Member

You can find a fix for this in Material 2.12.10. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-jonathan daniel-jonathan

Labels
bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MattKiazyk @daniel-jonathan