Allow some more programmatically changes #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mRs-
reviewed
Mar 21, 2017
| // let consoleController = TinyConsoleController(rootViewController: tabBarController, expandedHeight: 300) | ||
|
|
||
| // Show a startup | ||
| // consoleController.consoleWindowMode = .expanded |
|
hey @janniklorenz if you are going to clean this up we can merge this :) |
|
Since this is an example, I included these lines to demonstrate the usage. But if you want, I will remove it. |
|
A good documentation would be better then to clutter the example, or split in in the example in a new section. |
|
I like it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some cases it might me better to set the visibility of the console programmatically. So I changed
consoleWindowModeto public.Also added another init for
TinyConsoleControllerwhich uses a customexpandedHeight.