Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interchain Accounts / lupercalia #167

Closed
wants to merge 20 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Mar 21, 2022

This PR will bring ICA to Juno, as well as:

  • wasmd v0.24.0
  • ibc-go
  • an upgrade handler folder to better organize code
  • go 1.18
  • tighter linting

This PR should be applied after a governance "Software Upgrade" proposal to juno passes.

The governance "Software upgrade" proposal should not be made until this code has been merged to Juno's main branch.

@faddat
Copy link
Contributor Author

faddat commented Mar 21, 2022

Awesome @nghuyenthevinh2000!

Ok, now we just add the ica stuff which is here:

https://github.com/cosmos/ibc-go/blob/main/testing/simapp/app.go

@faddat
Copy link
Contributor Author

faddat commented Mar 21, 2022

we should also use wasmd from the same commit (nearly) as Osmosis -- but not totally the same unless we put osmo's fast iavl on juno, which... actually makes a lot of sense.

Yeah lets use this one:

osmosis-labs/wasmd#3

@faddat faddat marked this pull request as draft March 21, 2022 06:51
@faddat
Copy link
Contributor Author

faddat commented Mar 21, 2022

I am making a cosmos-sdk fork with @pomvn's fast iavl patch only, so we don't depend on osmosis-sdk

@faddat
Copy link
Contributor Author

faddat commented Mar 21, 2022

@giansalex
Copy link
Member

giansalex commented Mar 21, 2022

we can keep this pull request only for ibc-go v3 - ICA, and move iavl and other forks to other pull requests.
I also heard that iavl fork throws app_hash errors in osmosis, or does it have another cause?

go.mod Outdated Show resolved Hide resolved
@faddat
Copy link
Contributor Author

faddat commented Mar 21, 2022

no one really knows about those apphash errors, we can take fast iavl out

@vuong177
Copy link
Member

@faddat, i think we should remove iavl from wasmd

@faddat
Copy link
Contributor Author

faddat commented Mar 22, 2022

yes you're right and thanks very much vuong.

It was kind of all or nothing with fast iavl.

@faddat
Copy link
Contributor Author

faddat commented May 14, 2022

@vuong177 @nghuyenthevinh2000

Hey guys, this needs to be reworked. I'll click around a little, and see how much is needed.

@faddat
Copy link
Contributor Author

faddat commented May 14, 2022

Hey, I am going to close this in favor of #200

While writing that, it became apparent that it might as well be this.

@faddat faddat closed this May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants