Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Juno v10 #262

Merged
merged 12 commits into from Aug 27, 2022
Merged

Juno v10 #262

merged 12 commits into from Aug 27, 2022

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Aug 10, 2022

@the-frey, @JakeHartnell and I have talked a great deal about making faster, incremental releases.

So here's juno but more special:

  • tendermint v0.34.21
  • ibc-go v4.0.0
  • cosmos-sdk v0.45.7
  • iavl v0.19.1

All of these put together make for a leaner, meaner juno.

Deploy plan

This is a state breaking change because of ibc-go v4.0.0 It should be tested on Uni first.

Deploy timeline

We should play around and see how quickly (or not) we can get this out. The changes are in total quite minor, though they should make juno a good deal faster because we'll be using the Osmosis turbocharged iavl.

Addendum

This currently uses a notional-labs fork of wasmd. I think that this work is now good to go for Uni, but we should wait for this PR:

To be merged upstream before we take this live on mainnet.

There have been requests from the community to make our block times lower. When this PR is merged, various validators can/should begin lowering their commit timeout, and we can have faster juno, too. This is comfortable because of the turbocharged osmosis iavl (now just plain old iavl v0.19.1)

@faddat faddat marked this pull request as draft August 10, 2022 00:45
@sascha1337
Copy link

@faddat i saw some cosmos repos already using ibc go v4(alpha), any estimation if that would introduce breaking changes again? Will check the diff of v3v4 later today

@faddat
Copy link
Contributor Author

faddat commented Aug 14, 2022

definitely agree wiht your changes @the-frey

@faddat
Copy link
Contributor Author

faddat commented Aug 14, 2022

CosmWasm/wasmd#937

@faddat
Copy link
Contributor Author

faddat commented Aug 14, 2022

@faddat
Copy link
Contributor Author

faddat commented Aug 15, 2022

🔥

many thanks to Mr. David, another upstream swimmer, for

@faddat faddat changed the title ibc v3.1.1 sdk 457, tm 3420 ibc v4.0.0 sdk 457, tm 3420 Aug 15, 2022
@faddat faddat marked this pull request as ready for review August 15, 2022 20:07
@faddat faddat changed the title ibc v4.0.0 sdk 457, tm 3420 Juno v10 Aug 15, 2022
@faddat faddat mentioned this pull request Aug 15, 2022
6 tasks
@the-frey
Copy link
Collaborator

Changes look good, I'm just getting caught up now I'm back at my desk. I guess we want to test the blocks/inflation test first and then get this up on uni. Maybe that order.

@faddat
Copy link
Contributor Author

faddat commented Aug 21, 2022

yeah, so I think that this PR should be merged and referred to as the base of Juno v10

Agree that we should do the inflation thing, which likely reqires a gov prop.

Are you referring to the suggestion about making it linear instead of steps, or something else?

Also, this is honestly held up on

and

My preference is to merge this, then:

the-frey
the-frey previously approved these changes Aug 22, 2022
Copy link
Collaborator

@the-frey the-frey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I guess as we move towards an actual v10 RC main will become a working branch until the upstream wasmd changes go in.

@faddat
Copy link
Contributor Author

faddat commented Aug 25, 2022

That's the idea -- also since I figure that Juno is best off as a reference implementation of wasmd, we've also made a wasmd branch based from osmosis-- afaik unfinished.

@faddat
Copy link
Contributor Author

faddat commented Aug 25, 2022

Latest bump brought us current with this wasmd branch:

@faddat
Copy link
Contributor Author

faddat commented Aug 25, 2022

Modified superlinter.yml so that we don't check over go code twice.

@faddat
Copy link
Contributor Author

faddat commented Aug 25, 2022

FYI: this could easily be superceded by:

#270

They're now both in the same state in that for both PR's we are relying on a Notional fork of wasmd

This was referenced Aug 25, 2022
@dimiandre
Copy link
Member

FYI: this could easily be superceded by:

#270

They're now both in the same state in that for both PR's we are relying on a Notional fork of wasmd

I'd stick with SDK 45 for now, what do you think @JakeHartnell @the-frey ?

dimiandre
dimiandre previously approved these changes Aug 25, 2022
Copy link
Member

@dimiandre dimiandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@faddat
Copy link
Contributor Author

faddat commented Aug 25, 2022

given events of the past few hours, fully agree @dimiandre

Much better to stick with the 45 series.

@the-frey
Copy link
Collaborator

Yep stick with 45

@faddat faddat merged commit fd80169 into main Aug 27, 2022
@the-frey the-frey deleted the juno-11-rc branch August 30, 2022 09:30
@the-frey
Copy link
Collaborator

Leaving a note for self here: version 10 is not ready for production until we can revert to mainline wasmd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants