Merge Develop in Master

[ouziel-slama]

No description provided.

[adamkrellenstein]

How are we feeling about this, @JahPowerBit, @btcdrak, @xnova? Any problems running Counterwallet with it? Any problems with the new consensus-checking code?

[btcdrak]

This PR really got too big huh? 😸
I have looked over the code and I dont see anything objectionable. Not sure I could go as far as saying it's OK, but testnet is running.

Just a thought for future, when a version is ready with "protocol change" save that to a separate branch then merge those into master when you're happy with it. It means you can work on imperfections for later protocol changes that may not yet be ready for mainnet. This super develop branch thing is not idea for good QA.

[adamkrellenstein]

@btcdrak, @JahPowerBit, What do you think about making this PR without the consensus checks and without the dividend fee protocol change, at least for now? (Then it'll really be just the multi-sig and the test suite, right?)

[adamkrellenstein]

I'm inclined to merge it. @JahPowerBit, if you're OK with it, then I'll do the merge.

[ouziel-slama]

yeah sure! step by step is not bad! I just download the bootstrap database and launch a reparse with consensus, and works well.. but I'am not against keeping that on develop for more testing.
Just there is a problem with countepartyd_build and the database lock: when I stop counterpartyd with service counterpartyd restart/stop the .lock file is not removed, and counterpartyd stuck on "connecting to the database" step. Not sure what the best solution to resolve that (use always --force or change the way that counteparty_build stop the daemon).

[adamkrellenstein]

Make an issue for that---seems minor.

I'm going to merge this in a couple of minutes, without splitting it up.

[robby-d]

Ouziel, the command you specified is the old command... Does it still not stop properly with "sv stop counterpartyd"? (which is runit)... I haven't run into this with the new command (based on runit)

[robby-d]

Do the build scripts or launch commands need to be changed any? Anything else that may impact the build system?

[adamkrellenstein]

The only recent change is that you need to write the server in counterpartyd.py server explicitly. That may already be in master though. (Not in front of my computer.)

[ouziel-slama]

@xnova , yes just test on the beta server with sv restart ... It stuck at Status: Checking version.. To restart you need to sv stop .., delete ~/.config/counterpartyd/counterpartyd.9.db.lock then sv start...

[robby-d]

Is this just how it is? If so, we can modify the sv run script to issue this rm call after the counterpartyd invocation, whuch means after cpd exits/returns, it will remove the lock file

[ouziel-slama]

@xnova, yep. Don't find in counterpartd_build a way to make that (Seems there just a file run for each service)