Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Info] Chinese Translation Bounty (100 XCP) [$342 awarded] #510

Closed
ghost opened this issue Oct 7, 2014 · 39 comments
Closed

[Info] Chinese Translation Bounty (100 XCP) [$342 awarded] #510

ghost opened this issue Oct 7, 2014 · 39 comments

Comments

@ghost
Copy link

ghost commented Oct 7, 2014

Dominik Zynis is offering the equivalent of 100 XCP in BTC for a Chinese language translation through Bountysource.

https://www.transifex.com/projects/p/counterwallet/

--- The **[$342 bounty](https://www.bountysource.com/issues/5153355-info-chinese-translation-bounty-100-xcp?utm_campaign=plugin&utm_content=tracker%2F542579&utm_medium=issues&utm_source=github)** on this issue has been claimed at [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F542579&utm_medium=issues&utm_source=github).
@zynis
Copy link

zynis commented Oct 8, 2014

btw the bounty is actually 0.98 BTC (which was 100 xcp that i had to trade for btc at 0.00999 price and minus the coinbase.com fee) since bountysource does not support XCP payments at this time and must be complete in 3 months.

https://www.bountysource.com/issues/5153355-info-chinese-translation-bounty-100-xcp

Should be updated once the bountysource system sees my donation

I have no idea how the award is done, whoever owns the repo can look at the bountysource app and determine that.

good luck

@ghost
Copy link
Author

ghost commented Oct 8, 2014

You can look by the number of lines translated by each contributor.
Earlier (when the bounty was announced) the job was 19% complete and the number of lines is 700+, so that's about 598 lines to translate or 0.00167 or so per line.
If you have more than one taker, then you can look at how much each did and allocate proportionately.
You could make it much more complicated that that (like look at difficulty level of individual lines), of course, but that's a lot of extra work. Also, the approach above doesn't reward quality (someone could copy English to Chinese and be 100% done, or just do a crappy job in Chinese).

@zynis
Copy link

zynis commented Oct 8, 2014

it's up to the repo owner, i just donated to get the job done

@ghost
Copy link
Author

ghost commented Oct 8, 2014

I'm pokin' around, could use those BTC to buy more h/w

@robby-d
Copy link
Contributor

robby-d commented Oct 10, 2014

Could we get a review for the translation before we go live with it?

@adamkrellenstein
Copy link
Member

Re-opening until the translation can be reviewed. (Then the bounty will be paid out.)

@ghost
Copy link
Author

ghost commented Oct 11, 2014

We should definitively get it reviewed (all of them, not just this one).

  1. Public beta (on testnet, if need be) needs to run for 1-2 weeks to give the community a chance to review and comment in the forums
  2. Someone should also review it the traditional way for basic sanity (e.g. that sell is not translated as buy or send as receive)

@fox19891989
Copy link

So I need to wait at least for 2 weeks?

@ghost
Copy link
Author

ghost commented Oct 13, 2014

Noone said that review will take 2 weeks

@ouziel-slama
Copy link
Contributor

Just merge btcescrow branch with develop and activate Chinese on it. I update the beta server so everyone can review it:
https://beta.counterwallet.co/?testnet=1
https://beta.counterwallet.co/

@fox19891989
Copy link

Tks, JahPowerBit, let's waiting for the Chinese community response, I will modify typos/incorrect translation if there exists.

@ghost
Copy link
Author

ghost commented Oct 15, 2014

**Line: Remark**
707: Typo ("download" instead of "bet", in Chinese)
711: "Previous" - 前一个 may be better than 之前 (previously)
20: "To avoid having to type the full 12-word passphrase every time you log into Counterwallet," - > "为方便每次登录时输入12组词语密码," - 为方避免每次登录时输入12组词语密码 ("avoid" seems to be missing? I think the translation should be changed because it does not differ between (wallet) pass phrase and (Quick Access URL) password which is usually fine but when they're mentioned in the same sentence more clarity would be in better. 
23: "secret URL and use with your password for quick access:" - > "您可以使用它来访问您的钱包" - shouldn't this be 它和快速访问网址密码来访问您的钱包 or something like that?
49: Counterwalletd - > change to Counterpartyd (this is a typo in Source)
50: Extra period (.) can be deleted
63: Required BTC pays - "required" needs to be translated because the user needs to know BTC Pay has to be made otherwise transaction will fail to complete
72: Open Bets - This doesn't mean "make a bet", but all currently open bets, so it should be translated as 开放的 (to keep the same consistency with the word "open" from "open orders" which was translated as 开放的订单).
93: "If this option is enabled, Counterwallet will automatically take care of making BTC payments for matched orders where you owe BTC." - I would add "this" in translation, too, so that it is ""如果选择启动*此*功能" or 这项 instead of 此.
101 and 102: BTC Sell is translated as both "出售BTC" and "卖出BTC". I know it's "boring" to use the same term, but personally I prefer consistency (and I personally prefer 卖出BTC).
100 and 102: Expire is also translated as 过期 and 到期 (both are correct), but I'd also prefer to pick one (e.g. 过期, which is used more often in translation)
128: "I sent funds to a vending machine" -> "我发送资金参与了Vennd Machine支持的众筹项目". Instead of that, I'd say something like "我发送资金到令牌贩卖机, 为什么没有显示" (or 自动售货机 as it was used in line 479)
132:  Two factor authentication is not translated. It should be translated into Chinese (双因素验证).
164: 使用该地址交易或重试 should be better as 使用该地址交易再(or 并 if you want instead of 再)重试.
174: "Please try again later." is not translated into Chinese.
220: "It will automatically appear under the appropriate address once the network has confirmed it, and 当网络确认后,合适的地址会自动出现,并且你的地址" - please delete original English text from Chinese translation.
285, 286, 293, 294: "order ..will be placed." - > 将被放置. Shouldn't this be 将会完成? This is placing as in "putting down", but about completing the process of ordering.
285: "Your order to sell" -> 你的订单卖出. This should be 你的卖出订单.
305: "Settle" should be translated as 结算 or 完成, not as 解决.
786: "你拥有的已建立的市场价值的资产 (via completed trades on the Distributed Exchange) 列在这." - Untranslated English text should be translated (as 根据分布式交易所上已结算的交易市值 or something similar - it means that whatever asset/token has not been traded, it will not be listed as having value because the value is unknown; hence the precondition that it must have been traded on the DEx).
243: "Market Cap" - > 市值. It's OK, but it's better to translate as *total* market cap, 總市值, because some may take mean as 市值 to mean "market value" of an asset/token.
734: End User License Agreement (this single "line" has 1,200 English words of legalese; if you consider that the entire Counterwallet has 788 "strings" and 5,800 words (including the 1,200 of said CW License, that means that 20% (of most difficult, legal, text) has not been translated)
726: "No entries" - > 无法进入.  The meaning is 没有数据 or 没有信息(no data) rather than no physical entries.
716: "Cumul" - should be translated as 累積值 (original text wasn't clear enough)
685: Missing column (:) at the end of translation text should be added.
676: Counterparty (as in "other side in the deal") should probably be translated as "交易对手" or "游戏对手" rather than "另一面".
529: Burn for XCP -> 燃烧XCP.  I think this should be 燃烧比特币转为XCP.  This is not the burning of XCP, but the burning of BTC *for* XCP.
264: "Filled" -> 被填满的. 供应订单 should be used instead.
162: "Create Case" -> 创建案例.  Should be 创建服务要求 or 创建服务求助.

Some personal remarks:

  1. Because the License Agreement is not translated, 80% has been done while a difficult - if not most difficult - 20% in terms of word-count remains. Is that License Agreement supposed to be translated? Who is capable of translating (or reviewing) such translation?

  2. Prior to the announcement of a bounty, if I remember correctly about 18% was done when the project started (although when I did look few weeks ago I believe there were cases where HTML mark-up was simply dropped from translation (from 18% to 100% or 80% as is now) which was probably fixed by this translator). I don't know if the bounty applied to the entire job (and should be shared by all participants) or only for the uncompleted part.

I can't see in Trasifex who did how much when and personally I don't care how the bounty is paid/split, that info is just for the bounty owner to consider.

@adamkrellenstein
Copy link
Member

I don't think that the license agreement should be translated by anyone except a lawyer. Moreover, I think it's OK to leave it in English for everyone.

@btcdrak
Copy link
Contributor

btcdrak commented Oct 15, 2014

@PhantomPhreak ACK.

@fox19891989
Copy link

rippler,
1.I asked PhantomPhreak and he said I don't need translate the license agreement.
2. 100 xcp bounty should be the left part, because when the bounty was announced, it has been done 18%, and I did the left.
3. I will modify the typos, tks.

@ghost
Copy link
Author

ghost commented Oct 16, 2014

Sounds good!

@fox19891989
Copy link

49: Counterwalletd - > change to Counterpartyd (this is a typo in Source)
Counterpartyd or Counterparty?

  1. how many blocks a counterparty has to take the other side of the game.  合约币的游戏对手需要多少个区块的耗时  Is it OK? I can't understand this sentence actually, the game means bet game?.
    

The others have been modified(1-160 lines were done by Frozen123, and I helped him to modify his typos)

@ghost
Copy link
Author

ghost commented Oct 16, 2014

  1. Use Counterpartyd
  2. Something like 游戏对手需要多少个区块内动 - how long the other guy can wait before he has to pick rock/paper/scissor

@fox19891989
Copy link

Can I get my 100xcp bounty now? Review has been done and I modified all typos and incorrect words.

BTW, I just translated 17 new lines, plz review them, tks!

@ghost
Copy link
Author

ghost commented Oct 18, 2014

@JahPowerBit is there anything else that needs to be done?

@robby-d
Copy link
Contributor

robby-d commented Oct 20, 2014

@ripper if you feel the translation is good, @JahPowerBit can merge this in and put it live ASAP

@ghost
Copy link
Author

ghost commented Oct 20, 2014

Can we deploy it to the public beta server and invite people on the forums for a few days of testing?

@fox19891989
Copy link

Just go ahead, I hope when I get my bounty, it is worth 2btc.

When you are ready, plz tell @zynis to pay my bounty

Donations and tips are welcomed: 136NLJYypdTgrceWVRgup8gD8uNgFF5dk7

@zynis
Copy link

zynis commented Oct 21, 2014

how are things going?

just to clarify the bounty is for the translation of the User Interface into Chinese, not the legal contracts which should remain in english since I assume that choice of law jurisdiction is in there and is probably in the USA.

by the way the bounty will get awarded once User Acceptance Testing (UAT) has been completed with satisfactory marks.

Once you have a public IP feel free to post here and I will promote to people for testing.

Thanks everyone for doing this work.

btw i have no idea how the bounty award mechanism works. but i will talk to the bountysource guys if there is an issue.

btw the bounty was titled wrong, and payment is fixed to $343 https://www.bountysource.com/issues/5153355-info-chinese-translation-bounty-100-xcp/developers

@fox19891989
Copy link

Ok, the title is misleading, when you pay, plz pay in btc, I will give you my btc address when everything is ready..

@zynis
Copy link

zynis commented Oct 22, 2014

you need to have read the instructions. the payment is on bountysource.com. read this entire issue and take the time to click on the link to the actual bounty.

please do not waste my time.

@ghost
Copy link
Author

ghost commented Oct 22, 2014

@zynis the translation is on https://beta.counterwallet.io and https://beta.counterwallet.io?testnet=1 (testnet) and if no feedback is received by Friday I think we can conclude this.

@fox19891989
Copy link

I don't waste your time. just wanna get my money asap(waiting for 2 weeks already), why pay through bountystore, withdrawal fee is 10%, I have done the job in 1 day. Shouldn't help me save 10% fee?

my btc address: 16Y831TEgQaGkkuHtXYoum678wN5QG2Wcz

@zynis
Copy link

zynis commented Oct 23, 2014

First of all it is not your money until I say so, as it is my donation and my terms. If you don't follow my terms well then "too bad so sad" as the old saying goes.

Not my problem if you fail to read what I wrote.

"he who has the gold makes the rules"

@fox19891989
Copy link

Hi, how is User Acceptance Testing (UAT) going? I see no negative feedback on your posts, it seems successful, and when will UAT complete?

@zynis
Copy link

zynis commented Nov 2, 2014

I got positive feedback on this on bitcointalk, i will close this out and figure out how to do the tpayout on bountysource.com when i get back from visiting my family (Nov 5th)

@zynis
Copy link

zynis commented Nov 2, 2014

actually whoever opened this issue - can you please close this? apparently i cannot.

also anyone wanting to run this in production?

@ghost
Copy link
Author

ghost commented Nov 2, 2014

@goodtaster opened it, he can close it.
As far as I'm concerned it's OK to close it.

@fox19891989
Copy link

Nice to hear that

@zynis
Copy link

zynis commented Nov 5, 2014

ok one person has made a claim on bountysource.com - fox19891989

if no one else makes a claim (i guess to split the bounty or something) I will close this out in 24 hours and you all can go negotiate among yourselves if you feel like you deserve a piece.

@fox19891989
Copy link

Yes, I claimed it.

@fox19891989
Copy link

24 hours past, no other claims, can you pay now?

@fox19891989
Copy link

Got it, thanks your bounty

@ouziel-slama ouziel-slama added this to the 1.6.0 milestone Jan 6, 2015
@robby-d robby-d changed the title [Info] Chinese Translation Bounty (100 XCP) [Info] Chinese Translation Bounty (100 XCP) [$342 awarded] Feb 21, 2015
@robby-d robby-d added the bounty label Feb 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants