Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

Allow configurable image_identifier #45

Open
fonglh opened this issue Jun 28, 2016 · 1 comment
Open

Allow configurable image_identifier #45

fonglh opened this issue Jun 28, 2016 · 1 comment

Comments

@fonglh
Copy link
Member

fonglh commented Jun 28, 2016

def create_container(image)
    image_identifier = "coursemology/evaluator-image-#{image}"
    Coursemology::Evaluator::DockerContainer.create(image_identifier, argv: container_arguments)
  end

image_identifier is hardcoded to coursemology/evaluator-image-
Allow it to be configured through a command line option or environment variable so custom Dockerhub repositories can be used.

@fonglh
Copy link
Member Author

fonglh commented Jun 29, 2016

Soedar suggests that the entire identifier be customizable instead of just the Dockerhub organization.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant