Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private Key Format should be human readable #144

Closed
auxten opened this issue Dec 21, 2018 · 2 comments
Closed

Private Key Format should be human readable #144

auxten opened this issue Dec 21, 2018 · 2 comments

Comments

@auxten
Copy link
Contributor

auxten commented Dec 21, 2018

Background

CovenantSQL Private Key is encrypted with user inputted master key with a key hash suffix but stored in binary. It's not suitable for copy & paste or backup.

Goal

Private Key serialization and format can be identical with Bitcoin：

  1. https://en.bitcoin.it/wiki/Private_key
  2. https://en.bitcoin.it/wiki/Mini_private_key_format
@draveness
Copy link
Contributor

this maybe a broken change, is it acceptable? Or do I need to implement a compatible version for the original private key file loading function LoadPrivateKey?

@auxten
Copy link
Contributor Author

auxten commented Dec 21, 2018 •
edited
Loading

compatible is better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@auxten @draveness