Packet refactor

[jamesmunns]

Still planning to add some tests, but please feel free to review. I can also squash the commits once we are ready (I included them in case you wanted to see the steps).

[coveralls]

Coverage decreased (-0.3%) to 83.489% when pulling fb7deac on jamesmunns:packet-refactor into e1b04ce on Covertness:master.

[jamesmunns]

@Covertness ready to merge.

[coveralls]

Coverage decreased (-1.1%) to 82.682% when pulling 57ce239 on jamesmunns:packet-refactor into e1b04ce on Covertness:master.

[ptxmac]

You accidentally removed use coap::{CoAPServer, CoAPClient}; from the README

[jamesmunns]

Thanks for the catch. Is there any way to get cargo test to run the README.md examples so I can catch this in the future?

[coveralls]

Coverage decreased (-1.1%) to 82.682% when pulling f3aae2f on jamesmunns:packet-refactor into e1b04ce on Covertness:master.

[ptxmac]

A quick google search shows that the idea have been raised, but not closed: rust-lang/cargo#383
A possibility would be to try and add something like rustdoc --test README.md to the travis script

[Covertness]

The README example has another problem:

fn request_handler(req: CoAPRequest) -> Option<CoAPResponse> {
    println!("Receive request: {:?}", req);
    response
}

response should be request.response or None?

[coveralls]

Coverage decreased (-1.1%) to 82.682% when pulling 6049d9f on jamesmunns:packet-refactor into e1b04ce on Covertness:master.

[jamesmunns]

Made changes, the suggested rustdoc command didn't seem to work for me. I will look into this before adding it to the travis script. See below. Thanks again for the spot.

MacBook-Pro-2:coap-rs james$ rustdoc --test README.md 

running 3 tests
test coap_rs_0 ... FAILED
test coap_rs_2 ... FAILED
test coap_rs_1 ... FAILED

failures:

---- coap_rs_0 stdout ----
    <anon>:2:5: 2:23 error: can't find crate for `coap` [E0463]
<anon>:2     extern crate coap;
             ^~~~~~~~~~~~~~~~~~
error: aborting due to previous error
thread 'coap_rs_0' panicked at 'Box<Any>', ../src/libsyntax/errors/mod.rs:613
note: Run with `RUST_BACKTRACE=1` for a backtrace.
thread 'coap_rs_0' panicked at 'couldn't compile the test', ../src/librustdoc/test.rs:275

---- coap_rs_2 stdout ----
    <anon>:1:1: 1:19 error: can't find crate for `coap` [E0463]
<anon>:1 extern crate coap;
         ^~~~~~~~~~~~~~~~~~
error: aborting due to previous error
thread 'coap_rs_2' panicked at 'Box<Any>', ../src/libsyntax/errors/mod.rs:613
thread 'coap_rs_2' panicked at 'couldn't compile the test', ../src/librustdoc/test.rs:275

---- coap_rs_1 stdout ----
    <anon>:1:1: 1:19 error: can't find crate for `coap` [E0463]
<anon>:1 extern crate coap;
         ^~~~~~~~~~~~~~~~~~
error: aborting due to previous error
thread 'coap_rs_1' panicked at 'Box<Any>', ../src/libsyntax/errors/mod.rs:613
thread 'coap_rs_1' panicked at 'couldn't compile the test', ../src/librustdoc/test.rs:275


failures:
    coap_rs_0
    coap_rs_1
    coap_rs_2

test result: FAILED. 0 passed; 3 failed; 0 ignored; 0 measured