Divider color too harsh when using system color scheme

[ThatOneCalculator]

The problem

This may be a nitpick, but with no matter what color scheme I try from my wallpaper, the bar that separates notes is just too contrasted from the background.

Screenshots

Default color scheme (good)

System color scheme (bad)

App info

version 0.0.1

moe.craftplacer.kaiteki
versionCode 1672320354

targetSdk 33
minSdk 18

Installed: Dec 26, 2022; 10:53 AM
Updated: Dec 29, 2022; 8:12 PM

[Craftplacer]

I noticed it myself, and it even looks normal on the M3 specs, so I think it's a bug with Flutter how it decides the dividerColor or outlineVariant

[ThatOneCalculator]

Do you think you could fix that yourself, or override it with another color? Or is this something that has to be PR'd to flutter :(

[Craftplacer]

We already have an extension method called applyGeneralChanges which are Material theme tweaks that Kaiteki does, so maybe we could see how to adjust the colors to our liking.

[Craftplacer]

Found a related remote issue

material-foundation/flutter-packages#333

[ThatOneCalculator]

Good news? material-foundation/material-dynamic-color-flutter#58 (review)

You could also cherry pick that in, yeah?

[Craftplacer]

I prefer waiting for it to be merged.

[ThatOneCalculator]

Reopening. This is from the latest build

version 0.0.1

moe.craftplacer.kaiteki
versionCode 1675044174

targetSdk 33
minSdk 21

Installed: Dec 26, 2022; 1:53 AM
Updated: Jan 29, 2023; 10:32 PM

[tmaihoff]

What about material-foundation/material-dynamic-color-flutter#58 ? That pull request fixes the issue by adding outlineVariant.

[chaudharydeepanshu]

It's merged.

[Craftplacer]

It's merged.

Thanks for your fix 🙏, will update the package

[Craftplacer]

Issue fixed for real now ❤️