Set MACOSX_DEPLOYMENT_TARGET for macOS releases #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an effort to ideally produce "more portable" binaries for the releases we publish to GitHub. Currently the way macOS works is that you're generally only guaranteed to work on the same platform you built on and later (although it may sometimes work on older platforms). By configuring this environment variable it should be possible to lower the binary compatibility requirement, allowing running binaries on older OS releases than the build machine is running. I've chosen 10.9 here since it seems to be the lowest that "just works", but there's no particular reason other than that for choosing this. Rust itself chooses 10.8 (I think) for the compiler and 10.7 for the standard library. This decision is largely driven by the C++ code from wabt-sys which has more requirements about binary compatibility than Rust code does. Note that I don't actually have older macOS machines to test on as well, but I can at least confirm that this does affect the build process!
|
I should point out that I want to verify the release actually registers this before merging, so gonna wait on CI to finish the OSX build at least. |
alexcrichton
force-pushed
the
osx-releases
branch
from
c3ef59e
to
918916b
Compare
tschneidereit
approved these changes
Aug 6, 2019
|
Ok, verified and looks to be working! |
grishasobol
pushed a commit
to grishasobol/wasmtime
that referenced
this pull request
Nov 29, 2021
…ance#246) * Add MemoryInstance::direct_access and direct_access_mut * Rustfmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an effort to ideally produce "more portable" binaries for the
releases we publish to GitHub. Currently the way macOS works is that
you're generally only guaranteed to work on the same platform you built
on and later (although it may sometimes work on older platforms). By
configuring this environment variable it should be possible to lower the
binary compatibility requirement, allowing running binaries on older OS
releases than the build machine is running.
I've chosen 10.9 here since it seems to be the lowest that "just works",
but there's no particular reason other than that for choosing this. Rust
itself chooses 10.8 (I think) for the compiler and 10.7 for the standard
library. This decision is largely driven by the C++ code from wabt-sys
which has more requirements about binary compatibility than Rust code
does.
Note that I don't actually have older macOS machines to test on as well,
but I can at least confirm that this does affect the build process!