New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codecov and reporter for CI #167
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #167 +/- ##
==========================================
Coverage ? 80.51%
==========================================
Files ? 57
Lines ? 2910
Branches ? 0
==========================================
Hits ? 2343
Misses ? 567
Partials ? 0 |
These changes look good to me. Any idea why the badge on your branch's README shows codecov status as 'unknown'? |
Thanks @ben-albrecht |
@EricGustin, it seems you and @al-rigazzi have figured out the bug in the one ubuntu version? the decision for now is to skip torch there and recommend users go with RAI 1.2.5 if they are block on this correct? Otherwise is this ready to go in? |
Yeah @Spartee, it is a very specific PyTorch 1.7.1 + Python 3.9 (+ Ubuntu, possibly) problem. See e.g. this issue or one of the many other similar ones. This was then solved in PyTorch 1.8 So yes, I'll basically repeat what you wrote, as it would be my suggestion (but @EricGustin may have changed his mind, so he'll have the last word):
|
As Al said there is a bug with Ubuntu/Python3.9/PyTorch1.7.1 which has been documented in several tickets like the one linked above. @Spartee and @al-rigazzi I've configured the Yaml file such that torch is not installed for the matrix combination Ubuntu20.04/Python3.9/RedisAI1.2.3. CI is now passing, good to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing the Pytorch/Python issue
Adds new tutorial for data loaders and online training, which is rendered as a Notebook in documentation and can be run on a laptop. [ committed by @al-rigazzi ] [ reviewed by @Spartee ]
This PR adds running the coverage tests to the GitHub Actions CI. In addition to running the coverage tests, the resulting coverage report is uploaded to codecov, and a PR bot will report any coverage changes that a given PR causes. We also now have a codecov badge for our
README.md
.