This repository has been archived by the owner on Mar 19, 2021. It is now read-only.
Cleanup Code #1
Merged
Cleanup Code #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- TileEntity -> BlockEntity - Remove some unnecessary AWs
- Two new Gradle properties (create.mixin_export, create.debug_logs), each adds a sysprop for all run configs respectively. - Lock the wrapper task to use Gradle 6.8.3 BIN
I will fix its errors later (probably never fixed them)
…abs should be used. Renamed package to com.simibubi I don't know what to do with registrate Switched to tabs from spaces
PepperCode1
approved these changes
Mar 9, 2021
|
Any more comments before merge? Actually @PepperCode1 just merge when you feel like it |
|
no conflicts, is this good to merge? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, it's not only that.
TileEntitycom.simibubi.createThis branch should somehow be merged with the
backportbranch. I don't know how. Someone will have to resolve conflicts.