This repository has been archived by the owner on Mar 19, 2021. It is now read-only.
Runtime translations and config stuff #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to mostly work and be stable. I want to get this merged as soon as possible, I'll do other translations after that. |
|
Any objections before I merge? |
|
If it launches it's good enough for me :) |
|
It launches, translations work. I don't know if I broke existing features though - I've not been following the progress and so I don't know how to test those. |
|
I'll merge in 5 minutes |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will eventually expand to other resource pack / data pack entries. Translations are just the start.This is of course a draft as the branch is not complete.Update
This is not only ARRP now, I also added config validation. Why? Yes.