Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The menu button is missing, when used with mods, that add their language files to minecraft namespace #588

Closed
SplendidAlakey opened this issue Nov 14, 2022 · 16 comments
Labels
1.19 bug Something isn't working

Comments

@SplendidAlakey
Copy link

SplendidAlakey commented Nov 14, 2022

Describe the Bug

The Create menu button is missing on 1.19.2, if any mod, that adds its own language files into the minecraft namespace, is also present.

Reproduction Steps

  1. Install this build on Fabric
  2. Install a mod, that adds its own language files to the minecraft namespace, e.g. Incendium, BetterBiomeBlend, Consistency+.
  3. Run the game

Expected Result

There should be a menu button.

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Windows 10

Mod Version

0.5.0f

Minecraft Version

1.19.2

Other Mods

Incendium
BetterBiomeBlend
Consistency+

Additional Context

The issue is exclusive to Fabric, Quilt is unaffected.

@SplendidAlakey SplendidAlakey added the bug Something isn't working label Nov 14, 2022
@github-actions github-actions bot added the 1.19 label Nov 14, 2022
@JieningYu
Copy link

weird. Incendium is just a jarred datapack.

@AlphaMode
Copy link
Member

The mod is closed source can't really do anything

@SplendidAlakey
Copy link
Author

The mod is closed source can't really do anything

Yeah, figured as much. Should I keep the issue open for visibility or nah?

@Skidamek
Copy link

Incendium is completely server-side, you can just remove it from client

@SplendidAlakey
Copy link
Author

I'm not playing on a server, though.

@Skidamek
Copy link

Makes sense

@Skidamek
Copy link

However becouse Incendium mod is just a jarred datapack as JieningYu said, you can try to use a normal datapack version of Incendium https://www.planetminecraft.com/data-pack/incendium-nether-expansion/

@JieningYu
Copy link

No. there's a class in that mod

@AkashiiKun
Copy link

AkashiiKun commented Nov 14, 2022

The class is just an event registry which does nothing.
(Blurred something as I'm not supposed to use a decompiler)
image

And the only class is for forge.
Also, it doesn't even have the seed fix as is already in the vanilla game. So definitely with using the datapack is enough.

@JieningYu
Copy link

JieningYu commented Nov 14, 2022

so.. why Incendium can cause that?

@SplendidAlakey
Copy link
Author

It's caused by their language files somehow. I was wrong in my initial claim, that Quilt is unaffected by this bug, I just had my Incendium jar bootleg "patched". I moved their language files out of minecraft namespace to it's own to avoid a bug with Minekea. But I just tested a clean Incendium jar on Quilt and the bug occurred.

@SplendidAlakey SplendidAlakey changed the title [Fabric] The menu button is missing, when used with Incendium The menu button is missing, when used with Incendium Nov 14, 2022
@SplendidAlakey SplendidAlakey changed the title The menu button is missing, when used with Incendium The menu button is missing, when used with mods, that add their language files to minecraft namespace Nov 14, 2022
@SplendidAlakey
Copy link
Author

I updated the issue to reflect the actual bug: the menu button disappears, if another mod adds its own language files to minecraft namespace. Removed the logs, because there's nothing in them anyway.

I've experienced a similar issue before with Minekea, except, in their case, blocks have broken translation strings: chimericdream/minekea-fabric#67

@TropheusJ
Copy link
Member

Issue is probably this line

TropheusJ added a commit that referenced this issue Nov 17, 2022
super weird
@SplendidAlakey
Copy link
Author

Not fixed. The issue became worse after the patch (build 766), the button now doesn't appear at all, no mods, en_us game language. But this time, the logs do seem to mention a related error: https://gist.github.com/SplendidAlakey/c2ad83bc17cbb5e3b7ea04cddddab941

@TropheusJ
Copy link
Member

???

@TropheusJ TropheusJ reopened this Nov 17, 2022
TropheusJ added a commit that referenced this issue Nov 18, 2022
@TropheusJ
Copy link
Member

Super weird. I've encountered this issue before with Consistency+. Somehow having lang in the vanilla namespace makes translations just not work at the stage the button is added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.19 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants