Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.8.0 does not have SpriteStage included despite what docs say. #593

Closed
hayesmaker opened this issue Mar 30, 2015 · 6 comments
Closed

v0.8.0 does not have SpriteStage included despite what docs say. #593

hayesmaker opened this issue Mar 30, 2015 · 6 comments
Assignees

Comments

@hayesmaker
Copy link

Hi there,

i've used bower to get the v0.8.0 of easelJS.. and tried to use SpriteStage, but it doesn't seem to be included in our package... is this a problem? why are there different versions of the same version?

@lannymcnie
Copy link
Member

SpriteStage and SpriteContainer are part of the Version 0.8.0 release on GitHub, but are not included in the minified version, since it is not an often-used feature. You have to include them manually from GitHub.

Cheers.

@hayesmaker
Copy link
Author

I'm not using the minified version, I'm using the unminified version 0.8.0 from a bower install

@lannymcnie
Copy link
Member

The unminified (combined) version still represents the "core" library (it is the same as the minified lib, except the source is readable, and it contains comments). The SpriteStage/Container is not part of the core library, and not included.

It might make sense to modify the bower install to include the 2 WebGL classes. We will evaluate.

@lannymcnie lannymcnie reopened this Mar 31, 2015
@lannymcnie lannymcnie removed the FOL label Mar 31, 2015
@lannymcnie lannymcnie self-assigned this Mar 31, 2015
@hayesmaker
Copy link
Author

Sure, thanks.. in the meantime we can get them like this:

"EaselJS": "CreateJS/EaselJS#master",
"SpriteStage": "https://raw.githubusercontent.com/CreateJS/EaselJS/master/src/easeljs/display/SpriteStage.js",
"SpriteContainer": "https://raw.githubusercontent.com/CreateJS/EaselJS/master/src/easeljs/display/SpriteContainer.js"

The docs should probably explain the core library concept, and explain they aren't core files

@lannymcnie
Copy link
Member

I guess it could be more obvious. At the bottom of the main description it says "Note: SpriteStage is not included in the minified version of EaselJS."

We are considering adding an "easeljs-webgl" min file to the /lib folder, which contains the tagged version of the 2 classes.

Cheers.

@lannymcnie
Copy link
Member

There is a webgl minified version now, which should come down with a bower install. We are considering including this file on the next CDN release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants