Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin incompatible with Instant Inventory #1

Closed
SandroVA opened this issue Apr 20, 2023 · 11 comments
Closed

Plugin incompatible with Instant Inventory #1

SandroVA opened this issue Apr 20, 2023 · 11 comments

Comments

@SandroVA
Copy link

https://i.imgur.com/W6izKLp.png
https://i.imgur.com/0XnKn0z.png

7722 * 0.99 = 7644.78 - 2000 = 5644 so the alch should have been blocked? But it wasnt

@CreativeTechGuy
Copy link
Owner

That's very strange. I cannot reproduce the issue with the same item and settings you are using.

Can you provide some more detail about what you did? The expected behavior is that you'd click to cast the High Alchemy spell in your spellbook, and then the battlestaff in your inventory would disappear while you were selecting the item to cast the spell on. That is what happens for me when I just tested it.

If you can give me some detailed steps to follow, I'll happily try to reproduce it and fix if it's broken.

@CreativeTechGuy
Copy link
Owner

This is what I'm experiencing. It's not until I change the margin to -4,000 that the battlestaff is unblocked.

2023-04-20.14-17-16.mp4

@SandroVA
Copy link
Author

RuneLite_2023-04-20_17-18-22.mp4

@SandroVA
Copy link
Author

Figured it out. Seems like your plugin is conflicting with "Instant Inventory" not sure if theres something you can do about that or not.

@CreativeTechGuy
Copy link
Owner

Ah I was just about to ask if there was a plugin conflict. Thanks for your help figuring out the root cause!

I'll have contact that plugin author and see how we can work this out. It seems like that plugin won't work with any other plugin which affects item visibility as it'll override it. Appreciate the report!

@CreativeTechGuy
Copy link
Owner

@SandroVA I've added this incompatibility to the Known Issues in the README. Thank you so much for letting me know. Hopefully @elgbar and I can figure out a solution :)

@CreativeTechGuy CreativeTechGuy changed the title Plugin does not seem to work? Plugin incompatible with Instant Inventory Apr 20, 2023
@Nick2bad4u
Copy link

Im using instant inventory but its not blocking anything for me.

@CreativeTechGuy
Copy link
Owner

@Nick2bad4u It sounds like you are experiencing the same issue. Instant Inventory is the one that needs to fix the problem. Unfortunately since their plugin is overriding mine, I cannot fix it. Feel free to reply on the open issue in Instant Inventory's repository to help "motivate" them to fix it. 😉 elgbar/instant-inventory#8

@Nick2bad4u
Copy link

@Nick2bad4u It sounds like you are experiencing the same issue. Instant Inventory is the one that needs to fix the problem. Unfortunately since their plugin is overriding mine, I cannot fix it. Feel free to reply on the open issue in Instant Inventory's repository to help "motivate" them to fix it. 😉 elgbar/instant-inventory#8

I posted a comment there. Thanks!

@elgbar
Copy link

elgbar commented Sep 26, 2023

Just wanted to let you know that this should be fixed and live in-game runelite/plugin-hub#4872

@CreativeTechGuy
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants