Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mobile] Add a sorting strategy to the device list #266

Closed
Dynesshely opened this issue Jul 3, 2023 · 2 comments · Fixed by Crequency/KitX-Mobile#32
Closed

[Mobile] Add a sorting strategy to the device list #266

Dynesshely opened this issue Jul 3, 2023 · 2 comments · Fixed by Crequency/KitX-Mobile#32
Assignees
@Dynesshely
Labels
enhancement New feature or request

Comments

@Dynesshely
Copy link
Member

🪦 Is your feature request related to a problem? Please describe.

The order of the device cards in the device list on the mobile terminal is often messed up.

🪧 Describe the solution you'd like

Add default sorting strategy.

My suggestion is as follows:

  • The first device card defaults to this machine
  • The second device card defaults to the master device (if any)
  • Device cards for desktop OS (sorted by OS, I would like the order to be windows, linux, macos if possible)
  • Device cards for mobile operating systems (also sorted by operating system, first android, then ios)

🧾 Describe alternatives you've considered

Maybe we can provide other injection methods so that users can customize the sorting strategy.

📎 Additional context

No response
@Dynesshely Dynesshely added the enhancement New feature or request label Jul 3, 2023
@Dynesshely Dynesshely self-assigned this Jul 3, 2023
@Dynesshely Dynesshely mentioned this issue Jul 3, 2023
Open
30 tasks
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Tracked by #224 .

@github-actions github-actions bot added the tracking This issue is tracking by another issue label Jul 3, 2023
@Dynesshely
Copy link
Member Author

I accomplished this in Crequency/KitX-Mobile@a0096c2, I will open a PR to merge it later.

@Dynesshely Dynesshely mentioned this issue Jul 4, 2023
Merged
@Dynesshely Dynesshely removed the tracking This issue is tracking by another issue label Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dynesshely Dynesshely

Labels
enhancement New feature or request
Projects
KitX Project Todo-Lists
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Pull Request] Sort device cards, display more devices service status info Crequency/KitX-Mobile
1 participant
@Dynesshely