[Url Linkifier] Expand to cover www. urls #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance this has been looked over yet? |
|
Hoping to get this merged in soon, let me know if you have any questions about it! |
|
Checking in again! Hope you get to this soon! |
|
Checking in one more time to see if you have any comments or concerns? |
Cretezy
approved these changes
Nov 6, 2020
|
Sorry for the delay, thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit expands the UrlLinkifier to pick up http://, https://, and www. urls. If the url it picks up doesn't start with http:// or https://, then it will prepend http:// (or https:// depending on linkify options) to make it launchable from urlLauncher.