Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update resubmission function for new submission flow #403

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Update resubmission function for new submission flow #403

merged 2 commits into from
Nov 9, 2023

Conversation

BarryPiccinni
Copy link
Collaborator

@BarryPiccinni BarryPiccinni commented Sep 7, 2023 •
edited
Loading

Changes made:

  • Moved resubmission function from questionnaire-service.js to new submission-service.js
  • Moved resubmission route from routes.js to submission-routes.js
  • Skipped a failing test in the generated test file that related to the old submission flow

@BarryPiccinni BarryPiccinni self-assigned this Sep 7, 2023
@BarryPiccinni BarryPiccinni marked this pull request as ready for review September 7, 2023 15:39
Base automatically changed from cdbt-changes-new-submission to master September 7, 2023 15:51
@BarryPiccinni BarryPiccinni merged commit 1633d83 into master Nov 9, 2023
10 checks passed
@BarryPiccinni BarryPiccinni deleted the CDBT-resubmission branch November 9, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armoj armoj armoj approved these changes

@sinclairs sinclairs Awaiting requested review from sinclairs

@neil-stephen-mcgonigle neil-stephen-mcgonigle Awaiting requested review from neil-stephen-mcgonigle

Assignees

@BarryPiccinni BarryPiccinni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BarryPiccinni @armoj