Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] CSS image alignment #17

Closed
Dispositif opened this issue Jun 24, 2023 · 4 comments
Closed

[Bug] CSS image alignment #17

Dispositif opened this issue Jun 24, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@Dispositif
Copy link

With an image in portrait format, the active character's image is incorrectly aligned.
See example with 523x1000px image : https://zupimages.net/up/23/25/bk6d.jpg

@CristianVasile23
Copy link
Owner

Hey there, thanks for letting me know, I will look into it.

A fix should be available at the start of next week or maybe even tomorrow as I have been reworking a lot of the code and fixing several issues. I will see if this bug still happens in the upcoming version of the module, and if so, I will fix it.

@CristianVasile23 CristianVasile23 added the bug Something isn't working label Jun 25, 2023
@CristianVasile23 CristianVasile23 self-assigned this Jun 25, 2023
@CristianVasile23 CristianVasile23 changed the title bug CSS image alignment [Bug] CSS image alignment Jun 25, 2023
@CristianVasile23
Copy link
Owner

With version 5.0.1, I have added a fix to the bug you have found. That said, the active portrait behaved correctly, it was the smaller thumbnail that wasn't working properly.

By default, the portraits have their anchor set in the center, if you want to display them from the top to the bottom (as is the case for the picture you have provided), you have to go into the module settings and set the portrait anchor to Top.

For now, this setting is for all images, but I have plans to add the option to set the anchor position individually for each participant (for now, you can bypass this limitation by manually cropping the images that display incorrectly).

If you have any questions or issues, please do not hesitate to reach out.

@Dispositif
Copy link
Author

Nice fix with this global alignment option.
An alignment for each image seems an optimal idea, but will it be used by people ? Your module is actually simple to use and learn.

@CristianVasile23
Copy link
Owner

Hey again, I appreciate the feedback, one of the goals was to make the module easy to use and somewhat intuitive, so I am glad to hear that you found it that way.

Regarding the anchor option, if most people do not use it's whatever, the important thing is to at least have an option and more control over the display. The feature itself is going to be optional, by default the images will use the global setting, and if you need a specific image to be anchored differently, you can set it in the participant config. The goal is to give users flexibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants