-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REQUEST] add "inventory_image_type" "1" to resource/ui/econ/itemmodelpanel.res #107
Comments
oh, you can get rid of the second instance of "inventory_image_type" "1" that i put in contained_item_panel, because at the time i didn't realize UI elements that use an itemmodelpanel would inherit all settings from the itemmodelpanel in MainContentsContainer (anything else set in other itemmodelpanels overrides the setting put in, for example, if i had an itemmodelpanel in hudweaponselection with an fov of 75, those model panels for that specific hud element would use 75 fov, but every other model panel, unless specified will use the default fov setting in MainContentsContainer, which is 54) |
Instead of adding multiple inventory_image_type variables to files, add it to `resource/ui/econ/itemmodelpanel.res`. This will propagate the effect to majority of screens where item images are shown. Removed inventory_image_type previously added for this project as they are now made redundant. Huge credit to Whurrhurr for finding this change. Co-Authored-By: Whurrhurr <33162051+Whurrhurr@users.noreply.github.com>
That's a great find. I've pushed the change in 41da04b. Could you verify when you get the chance? It looked good from my testing. Also, you should publish this to the Steam Workshop. This is a much better way to implement this change then adding dozens of |
I've kept instances of |
can confirm it works, the only problem i've run into is that certain backpack icons do not get dimmed when you cannot select them (because they conflict with something else you have equipped) and the cause seems to be that those icons' _large vmts lack "$vertexcolor" 1 |
It shouldn't be a problem for Valve to add then if they decide to add this change into the game officially. I think for the scope of this mod this is sufficient. If you do end up making a Workshop submission of this, it'd be good to include a README note to Valve about that issue though. |
Is your feature request related to a problem? Please describe.
achieves the same effect as adding "inventory_image_type" "1" to say, hudweaponselection's itemmodelpanels (the panels on the right of your hud if you have weapon quick switch disabled, or if you press 0, but that file isn't touched by this mod, so the icons show up blurry)
examples:
hudupgradepanel
hudweaponselection
(i don't know what res file this is, but i do know that the icons are blurry even with the mod installed)
all of these are not touched by this mod, and they both have crispy clear weapon icons now. all screenshots were taken without the mod installed.
if you want to see this for yourself, here's the file.
itemmodelpanel.zip
The text was updated successfully, but these errors were encountered: