Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] add "inventory_image_type" "1" to resource/ui/econ/itemmodelpanel.res #107

Closed
Whurrhurr opened this issue Feb 21, 2023 · 6 comments
Assignees
Labels
request/suggestion Request or suggestion for a new change.

Comments

@Whurrhurr
Copy link
Contributor

Is your feature request related to a problem? Please describe.
achieves the same effect as adding "inventory_image_type" "1" to say, hudweaponselection's itemmodelpanels (the panels on the right of your hud if you have weapon quick switch disabled, or if you press 0, but that file isn't touched by this mod, so the icons show up blurry)

examples:
hudupgradepanel
image

hudweaponselection
image

(i don't know what res file this is, but i do know that the icons are blurry even with the mod installed)
image

all of these are not touched by this mod, and they both have crispy clear weapon icons now. all screenshots were taken without the mod installed.

if you want to see this for yourself, here's the file.
itemmodelpanel.zip

@Whurrhurr Whurrhurr added the request/suggestion Request or suggestion for a new change. label Feb 21, 2023
@CriticalFlaw CriticalFlaw self-assigned this Feb 21, 2023
@Whurrhurr
Copy link
Contributor Author

oh, you can get rid of the second instance of "inventory_image_type" "1" that i put in contained_item_panel, because at the time i didn't realize UI elements that use an itemmodelpanel would inherit all settings from the itemmodelpanel in MainContentsContainer (anything else set in other itemmodelpanels overrides the setting put in, for example, if i had an itemmodelpanel in hudweaponselection with an fov of 75, those model panels for that specific hud element would use 75 fov, but every other model panel, unless specified will use the default fov setting in MainContentsContainer, which is 54)

CriticalFlaw added a commit that referenced this issue Feb 26, 2023
Instead of adding multiple inventory_image_type variables to files, add it to `resource/ui/econ/itemmodelpanel.res`.

This will propagate the effect to majority of screens where item images are shown.

Removed inventory_image_type previously added for this project as they are now made redundant.

Huge credit to Whurrhurr for finding this change.

Co-Authored-By: Whurrhurr <33162051+Whurrhurr@users.noreply.github.com>
@CriticalFlaw
Copy link
Owner

That's a great find. I've pushed the change in 41da04b. Could you verify when you get the chance? It looked good from my testing.

Also, you should publish this to the Steam Workshop. This is a much better way to implement this change then adding dozens of inventory_image_type to files.

@CriticalFlaw
Copy link
Owner

I've kept instances of inventory_image_type that already exist in the default HUD and only removed ones added for this mod. Just to keep things as close to the default as possible.

@Whurrhurr
Copy link
Contributor Author

That's a great find. I've pushed the change in 41da04b. Could you verify when you get the chance? It looked good from my testing.

can confirm it works, the only problem i've run into is that certain backpack icons do not get dimmed when you cannot select them (because they conflict with something else you have equipped) and the cause seems to be that those icons' _large vmts lack "$vertexcolor" 1

@CriticalFlaw
Copy link
Owner

It shouldn't be a problem for Valve to add then if they decide to add this change into the game officially. I think for the scope of this mod this is sufficient. If you do end up making a Workshop submission of this, it'd be good to include a README note to Valve about that issue though.

@valeriedesumo
Copy link

I don't feel that the "HQ" backpack images are a direct objective upgrade, and so would be better suited for the extras folder. This change makes the items very aliased, and this can be seen in the attached comparison images. Details like the gears on refined metal, thin lines on earbuds and seal mask, and any diagonal like on direct hit all show strong aliasing. Additionally, some details look (subjectively) better on "LQ", such as the squad surplus looking more like a printed ticket, and the quackenbirdt's lines around the duck becoming more uniform. However, some details are better with the change like the fortified compound's bowstring becoming much more visible.

With "inventory_image_type" "1"
hq
Without "inventory_image_type" "1"
lq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request/suggestion Request or suggestion for a new change.
Projects
None yet
Development

No branches or pull requests

3 participants