-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom MvM missions fixes #149
Conversation
looks bad but better than obscuring the information entirely; a proper hud-only implementation would require a reshuffle of the whole mvm scoreboard
Added red team playercount center aligned under difficulty label, should be non-intrusive in 'normal' play and hopefully useful on custom missions with extended player counts. |
Could you post comparison screenshots please? |
…ar, limited extended playerlist to above stats panel
Capture the Flag HUD fixDoesn't seem possible to also remove the bomb upgrade indicators with this method. Added RED PlayercountDifficulty panel also needed moving because in its original position it can intersect with the wavebar on some missions. Difficulty panel is placed below the player count because it isn't visible on custom missions. Increased playerlist length past backgroundDoing a real fix for this without departing from the Valve-style scoreboard seems tough, as the actual background colour to each player on the scoreboard is hardcoded to change based on their alive status, making a dynamically resizing scoreboard seemingly impossible unlike in casual.
Has no impact on HUD when playing Valve missions. |
Hi. This is still in my queue to review and merge in. I need to finish and merge in the in-game customizations menu first then I'll look into this. Thank you for your patience. |
I removed redundant lines for the MvM player count placement because only x/y pos needed to be changed for the desired effect. I also reverted the player list extension because it doesn't fix the problem only make it worst by creating overlaps. Best to leave that one to valve. |
Everything else looks good. Merging and Thank you. |
Co-Authored-By: fellen <21310017+mtxfellen@users.noreply.github.com>
Co-Authored-By: fellen <21310017+mtxfellen@users.noreply.github.com>
Fixes two things:
The first fix listed works as intended with no side effects.
The second 'fix' is admittedly a hacky solution in which the playerlist is just made arbitrarily long; without completely reshuffling the MvM scoreboard, there's no good HUD-only fix for this, but I figure it's better than obscuring that information entirely? Though, of course, please deny that 'fix' if it's outside the scope of the project.
These changes have no visual impact on the HUD when otherwise playing Valve standard MvM missions.