Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Master #3

Merged
merged 2 commits into from Sep 2, 2015
Merged

Master #3

merged 2 commits into from Sep 2, 2015

Conversation

yamikuronue
Copy link
Contributor

Fix for issue #2

@evil-shrike
Copy link
Contributor

Thanks for contributing!
I think it makes sense to delete an existing file first to prevent merging with a previous result.

grunt.file.delete(coverageFilePath)

@yamikuronue
Copy link
Contributor Author

Yeah, but probably that needs to be done before qunit is launched. Otherwise you'd be overwriting the previous url's result again :)

@evil-shrike
Copy link
Contributor

probably that needs to be done before qunit is launched

Sure. But there's already grunt.file.delete(dest); at the beginning of coverageInstrument task.

evil-shrike added a commit that referenced this pull request Sep 2, 2015
@evil-shrike
Merge pull request #3 from yamikuronue/master
15d6af9 
#3
@evil-shrike evil-shrike merged commit 15d6af9 into croc-code:master Sep 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yamikuronue @evil-shrike