Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: increase contrast between menus and app background #3164

Open
emilydrakesmith opened this issue Oct 30, 2023 · 1 comment
Open
Labels
accessibility Improvement for disabled users and adaptive technology blocked Work on this issue is blocked by another issue bug Something isn't working enhancement New feature or request look-and-feel needs-design Blocked on either mockup or design

Comments

@emilydrakesmith
Copy link
Contributor

emilydrakesmith commented Oct 30, 2023

Requirements

Several of our dropdown menus use the same background color as the general background of the app body (specifically rgb(23, 29, 39) ). This causes accessibility issues because there isn't any contrast to distinguish the elements.

For both general usability and accommodation for visually-impaired users, no element with a given background color should be superimposed without interruption on top of another element with the same background color. When opening a dropdown, the user should be able to see before interacting exactly where are the bounds of that dropdown in the DOM without interacting.

We can rectify through one of several options:

  1. GOOD Create a new background color which is only used as a background for dropdown menus with no other application in the codebase
  2. BETTER Add a border around the dropdown menu, 2-3 px should be sufficient
  3. BEST Both of the above options in concert

@miyuki-eto Please review and communicate desired fix.

Network Switcher:

Explore ~ Ambient 2023-10-30 16-45-44

Resource Links:

Explore ~ Ambient 2023-10-30 16-50-09

Figma

No response

Assumptions

No response

@emilydrakesmith emilydrakesmith added enhancement New feature or request look-and-feel blocked Work on this issue is blocked by another issue needs-design Blocked on either mockup or design accessibility Improvement for disabled users and adaptive technology bug Something isn't working labels Oct 30, 2023
@miyuki-eto
Copy link

miyuki-eto commented Nov 1, 2023

i have amended the header menu background colours (dark4) and added a border (accent1, 1px). this is in the figma and can be found here -

https://www.figma.com/file/0ItLk4nJmtj741R8sn3HYp/ambient?type=design&node-id=4438-61118&mode=design&t=GK2XcMpIXQwISxo7-4

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Improvement for disabled users and adaptive technology blocked Work on this issue is blocked by another issue bug Something isn't working enhancement New feature or request look-and-feel needs-design Blocked on either mockup or design
Projects
None yet
Development

No branches or pull requests

2 participants