Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JetWooBuilder 2.1.10 - Products Grid widget shows products although query builder query does not return products #7355

Closed
xitromedia opened this issue Feb 10, 2024 · 1 comment
Assignees

Comments

@xitromedia
Copy link

xitromedia commented Feb 10, 2024

Describe the bug
When using a JetEngine juery builder query and that query does not return a result, the products grid lists all products using the number of posts setting from the widget's query settings, which results in showing wrong products although there should none be shown and only a message appear that nothing was found.

After wasting a lot of time (yes, i am angry because of that) i found the place where the code is buggy:

jet-woo-builder/includes/shortcodes/traits/products-shortcode.php > query() line 24

If the query builder query returns an empty result array there, the widget's query will be executed, which is not wanted, i assume.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@Crocoblock
Copy link
Owner

Hi @xitromedia

Fixed and released in version 2.1.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants