Skip to content
This repository has been archived by the owner on Feb 16, 2021. It is now read-only.

defaultConfig change locale's timeFormat #166

Open
padinko opened this issue Sep 26, 2018 · 1 comment
Open

defaultConfig change locale's timeFormat #166

padinko opened this issue Sep 26, 2018 · 1 comment

Comments

@padinko
Copy link

padinko commented Sep 26, 2018

Hi,

I am developing multi-locale application and I have a problem. Your defaultConfig contains timeFormat and it replace timeFormat from locale setting.
So my question is why you hardcoded this value (to european time format) and is it necessary?
I think you can remove this value from defaultConfig and let fullcalendar to use locale timeFormat or devs can set it in theirs config.

Now I need to replace your hardcoded timeFormat with this option:

            calendarConfig() {
                return {
                    locale: this.portal.lang,
                    timeFormat: null,
                    ...
                }
            },

Edit 1:
Maybe aspectRatio have same problem, it is unnecessary to hardcode it in defaultConfig, leave fullcalendar's default and let dev to adopt it

@Adrek
Copy link

Adrek commented Jun 12, 2019

Please, add prop timeFormat. Currently this props doesn't work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants