Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websockets: error-handler could include reason #454

Closed
MichaelSB opened this issue Jun 4, 2022 · 1 comment · Fixed by #476
Closed

Websockets: error-handler could include reason #454

MichaelSB opened this issue Jun 4, 2022 · 1 comment · Fixed by #476
Labels
feature Code based project improvement

Comments

@MichaelSB
Copy link
Contributor

MichaelSB commented Jun 4, 2022

I somehow miss information on the actual error in the error-handler of websockets. We have a string reason in the close-handler, but other than "some error happened" we get nothing in the error-handler. Maybe a string as well? For boost::system::error_code, we could use ec.message(). Other errors could just give some hardcoded string. Or probably some enum, which error-handlers could switch on? A combination (struct)? Opinions?

@The-EDev The-EDev added the feature Code based project improvement label Jun 4, 2022
@MichaelSB
Copy link
Contributor Author

Cool! Many thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Code based project improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants