splitted crow features into two options #770
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gittiver
force-pushed
the
split-crow-feature-options
branch
3 times, most recently
from
120ecd7
to
d57a913
Compare
gittiver
requested review from
mrozigor,
dranikpg,
The-EDev and
luca-schlecker
mrozigor
reviewed
Mar 8, 2024
| @@ -48,7 +48,10 @@ option(CROW_AMALGAMATE "Combine all headers into one" OFF) | |||
| option(CROW_INSTALL "Add install step for Crow" ON ) | |||
|
|
|||
| # Possible values: ssl, compression | |||
| option(CROW_FEATURES "Enable features extending Crow's abilities" "") | |||
| #option(CROW_FEATURES "Enable features extending Crow's abilities" "") | |||
There was a problem hiding this comment.
I guess you can remove this line.
|
moved back to draft, as options are incompatible and therefore also there documentation has to be adapted. |
gittiver
force-pushed
the
split-crow-feature-options
branch
2 times, most recently
from
c7f58f6
to
4457071
Compare
gittiver
force-pushed
the
split-crow-feature-options
branch
from
4457071
to
fb370ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.