Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat Example miss-leading #786

Open
arcliox opened this issue Mar 21, 2024 · 0 comments
Open

Chat Example miss-leading #786

arcliox opened this issue Mar 21, 2024 · 0 comments
Labels
feature Code based project improvement

Comments

@arcliox
Copy link

arcliox commented Mar 21, 2024

example_chat.cpp line 30: crow::mustache::set_base(".");

This line sets the base directory where mustache looks for the template, however this example is miss-leading, unless a custom templates base is set via a blueprint the handle() function of the DynamicRule class sets the directory back to "templates". Moreover if a blueprint is set this would overwrite what the above line does in any case.

Example works if build as part of the Crow build as the CMakeLists file copies the relevant template for this example into ./templates/.

Suggested fix remove line 30.

@gittiver gittiver added the feature Code based project improvement label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Code based project improvement
Projects
None yet
Development

No branches or pull requests

2 participants