Clarify state in Ace.HTTP.Server

[CharlesOkwuagwu]

Ace/lib/ace/http/server.ex

Lines 51 to 68 in e39bfbf

	def handle_call({:accept, {:tcp, listen_socket}}, from, state) do
	case :gen_tcp.accept(listen_socket) do
	{:ok, socket} ->
	:ok = :inet.setopts(socket, active: :once)
	state = %{state | socket: socket}
	{:ok, worker} = Supervisor.start_child(state.worker_supervisor, [:the_channel])
	monitor = Process.monitor(worker)
	state = %Ace.HTTP1.Endpoint{
	status: {:request, :response},
	socket: {:tcp, socket},
	# Worker and channel could live on same key, there is no channel without a worker
	channel: {:http1, self(), 1},
	worker: worker
	}
	GenServer.reply(from, {:ok, self()})
	:gen_server.enter_loop(Ace.HTTP1.Endpoint, [], {"", state})

Is the state from Line:51 the same state that's being overwritten on line on Line:59?

If yes, then line Line:55 is unnecessary ... same appears again further down.
This would also make :socket unnecessary in defstruct [:worker_supervisor, :settings, :socket]

[CrowdHailer]

A cursory glance suggests line 55 is unnecessary. I can't explicitly remember typing that line. I would just delete it and check all the tests pass.

If doing so introduces a bug but no test fails then we discover a new test that needs writing

[CrowdHailer]

Did you try the tests with this line deleted

[CharlesOkwuagwu]

Yes. It works the same with that line commented out.