Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ BUG ] Invoke-FalconDeploy fails to run .sh files on Linux targets when using PowerShell Core #219

Closed
bk-cs opened this issue Jul 1, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@bk-cs
Copy link
Collaborator

bk-cs commented Jul 1, 2022

Describe the bug
When using Invoke-FalconDeploy in PowerShell Core on any OS with -File pointing to a bash script, Invoke-FalconDeploy mistakenly formats the run command as

runscript -Raw=``` ``` -HostPath=```"/tmp/<FalconDeploy_directory>/<script>.sh"```

instead of the proper formatting

runscript -HostPath="/tmp/<FalconDeploy_directory>/<script>.sh"

To Reproduce

Invoke-FalconDeploy -File script.sh -Id <host_id>,<host_id>

Expected behavior
Proper execution of the script

Environment (please complete the following information):

  • OS: Windows 10, MacOS Monterey
  • PowerShell: PowerShell 7.2.4
  • PSFalcon: 2.2.0
@bk-cs bk-cs added the bug Something isn't working label Jul 1, 2022
@bk-cs bk-cs self-assigned this Jul 1, 2022
@bk-cs
Copy link
Collaborator Author

bk-cs commented Jul 1, 2022

This issue was indirectly fixed in v2.2.1 with some changes to how scripts are executed. Instead of using run with HostPath, now the scripts are executed using runscript with a script wrapper.

@bk-cs bk-cs mentioned this issue Jul 5, 2022
@bk-cs bk-cs closed this as completed Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant