Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silent fail when run parallel and invalid image file #31

Open
Ftelf opened this issue Aug 7, 2019 · 1 comment
Open

silent fail when run parallel and invalid image file #31

Ftelf opened this issue Aug 7, 2019 · 1 comment

Comments

@Ftelf
Copy link

Ftelf commented Aug 7, 2019

When base image file is invalid ie. by bad checkout or corruption the test fails by:
(node:109280) UnhandledPromiseRejectionWarning: Error: Invalid file signature at module.exports.Parser._parseSignature (C:\git\vendavo-frontend\vendavo-price-optimization\node_modules\pngjs\lib\parser.js:50:18) at module.exports.ChunkStream._processRead (C:\git\vendavo-frontend\vendavo-price-optimization\node_modules\pngjs\lib\chunkstream.js:174:13) at module.exports.ChunkStream._process (C:\git\vendavo-frontend\vendavo-price-optimization\node_modules\pngjs\lib\chunkstream.js:193:14) at module.exports.ChunkStream.write (C:\git\vendavo-frontend\vendavo-price-optimization\node_modules\pngjs\lib\chunkstream.js:61:8) at module.exports.ChunkStream.end (C:\git\vendavo-frontend\vendavo-price-optimization\node_modules\pngjs\lib\chunkstream.js:74:10) at exports.PNG.PNG.end (C:\git\vendavo-frontend\vendavo-price-optimization\node_modules\pngjs\lib\png.js:98:16) at exports.PNG.PNG.parse (C:\git\vendavo-frontend\vendavo-price-optimization\node_modules\pngjs\lib\png.js:88:8) at Jimp.parseBitmap (C:\git\vendavo-frontend\vendavo-price-optimization\node_modules\jimp\index.js:297:17) at C:\git\vendavo-frontend\vendavo-price-optimization\node_modules\jimp\index.js:202:29 at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:525:3)
silently and does not report a fail:
Process finished with exit code 0

@Ftelf
Copy link
Author

Ftelf commented Aug 8, 2019

Fixed in PR #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant