Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image size difference does not count #38

Open
Ftelf opened this issue Oct 14, 2020 · 0 comments
Open

Image size difference does not count #38

Ftelf opened this issue Oct 14, 2020 · 0 comments

Comments

@Ftelf
Copy link

Ftelf commented Oct 14, 2020

If the baseline and screenshot image sizes differs in sized (width and height) the Jimp.diff does not care and compare them as resizes. Since we care about true visual regression in web UI, this should be handled at least as explicit setting or optional parameter. Since I really care if the element just stretch itself instead of stay 1:1 pixel match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant