Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot test on windows #13

Open
meszaros-lajos-gyorgy opened this issue Jun 22, 2017 · 1 comment
Open

Cannot test on windows #13

meszaros-lajos-gyorgy opened this issue Jun 22, 2017 · 1 comment

Comments

@meszaros-lajos-gyorgy
Copy link

meszaros-lajos-gyorgy commented Jun 22, 2017

When I checkout the code on a Windows 7 machine, it automatically transforms every line ending from LF to CRLF and this makes the tests explode.

I can edit my git configuration to not turn line endings automatically to windows style by calling git config --global core.autocrlf true, but it seems like an unnecessary extra round for windows users to do, since git will change the line endings back to LF when I commit. (By the way, these are the default settings for git on windows)

I would be happier, if that option would be removed from the tests.

@meszaros-lajos-gyorgy
Copy link
Author

meszaros-lajos-gyorgy commented Jun 22, 2017

There is also some inconsistency between the local prettier/prettier module, which I just installed and on the CI tool when it comes to template strings:

CI version:

ci

Local version:

local

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant