Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/apple framework #54

Merged
merged 9 commits into from Apr 30, 2020
Merged

Feat/apple framework #54

merged 9 commits into from Apr 30, 2020

Conversation

HendX
Copy link
Contributor

@HendX HendX commented Apr 30, 2020

This contains the changes to app and the mock framework to use the ExposureNotification framework.

Note that you need the following entitlement to actually use the real framework, which must be manually given to you by Apple.

com.apple.developer.exposure-notification entitlement

@HendX
Copy link
Contributor Author

HendX commented Apr 30, 2020

@tatey With the newly-updated framework spec released by Apple today, there's now a risk level value that needs to be stored on the server. I've called this value l. The KeyServer.yaml file is updated accordingly.

@HendX HendX merged commit ce38301 into master Apr 30, 2020
@tatey
Copy link

tatey commented Apr 30, 2020

Should the array of objects in deleted_keys also have the l property? Otherwise I feel like you could reduce this done just to the d property. Either way, it would be inconsistent with keys and I can imagine that would make decoding harder since you'd either need to make them optional properties or you'd make a different struct.

@tatey
Copy link

tatey commented Apr 30, 2020

FYI this has been done in tatey/trace_privately@f7b8444.

@sgtcoolguy
Copy link

@HendX Dumb question, but how did you figure out about the entitlement? My attempts to activate an ENManager seem to give me this error:

getting ENManager: Error Domain=NSOSStatusErrorDomain Code=-71148 "kInvalidatedErr (XPC connection invalidated)" UserInfo={NSLocalizedDescription=kInvalidatedErr (XPC connection invalidated), cuErrorDesc=kInvalidatedErr (XPC connection invalidated), cuErrorMsg=XPC connection invalidated}

@mladjan
Copy link

mladjan commented Apr 30, 2020

This contains the changes to app and the mock framework to use the ExposureNotification framework.

Note that you need the following entitlement to actually use the real framework, which must be manually given to you by Apple.

com.apple.developer.exposure-notification entitlement

What is a process to get this entitlement key from Apple?

@HendX
Copy link
Contributor Author

HendX commented Apr 30, 2020

@HendX Dumb question, but how did you figure out about the entitlement? My attempts to activate an ENManager seem to give me this error:

What is a process to get this entitlement key from Apple?

Please refer to #57 for discussion on this.

@HendX
Copy link
Contributor Author

HendX commented Apr 30, 2020

@tatey Technically it could probably just be d, but I'm using r to differentiate between duplicated keys (this is helping me with testing). The l value is not needed.

The deleted_keys array is likely to be extremely small, since it's not for expired keys - just keys that were incorrectly approved - so I'm not worried about it blowing out in size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants