Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Titles - Issue #31

Closed
EazyFTW opened this issue Jun 25, 2020 · 4 comments
Closed

Titles - Issue #31

EazyFTW opened this issue Jun 25, 2020 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@EazyFTW
Copy link

EazyFTW commented Jun 25, 2020

Description
Clearing a title isn't working due to 1.16.1 most likely:
https://i.eazyftw.com/KxMvE3H.java

Version
1.16.1

@EazyFTW EazyFTW added the bug Something isn't working label Jun 25, 2020
@CryptoMorin
Copy link
Owner

CryptoMorin commented Jun 26, 2020

You're using your own version.
com.eazyftw.ezcolors.versions.messages.Titles.clearTitle(Titles.java:254)
I can't know the exact line of the original file if you don't use that.

@EazyFTW
Copy link
Author

EazyFTW commented Jun 26, 2020

@CryptoMorin
Copy link
Owner

CryptoMorin commented Jun 26, 2020

It's obviously not the same file, where did you get the number "233" from the error you posted? Whether you added or removed things, it's still not the same file. I don't want to just guess the line.

Anyways, I found the solution.
The clear method ignores if Bukkit can handle this or not.
For now you can fix it on your side with a simple check in the clear method:

if (SUPPORTS) {
   player.resetTitle();
   return;
}

@EazyFTW
Copy link
Author

EazyFTW commented Jun 26, 2020

I copied the file and the legal stuff was in it 2 times accidentally, but it's the same file. For now, I just made it send a blank title for 1 stick instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants