Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soul Flame on crossbows #38

Open
Vic-PT opened this issue Feb 13, 2024 · 3 comments
Open

Soul Flame on crossbows #38

Vic-PT opened this issue Feb 13, 2024 · 3 comments
Assignees
Labels
compatibility Not compatible with other mod, needs work from us no priority Work only if there's nothing else to do other mod Not compatible with other mod, needs work from them pending Waiting for something

Comments

@Vic-PT
Copy link

Vic-PT commented Feb 13, 2024

Soul flame, acts like regular flame on crossbows.

Would realy like it if the soul flame enchantment worked correctly on crossbows, making the flame blue and causing soul burning. I'm not asking for soul flame to be compatible with crossbows, I already have a mod for that.

I'm using universal enchants to get the soulflame enchantment on the crossbow.

@Vic-PT Vic-PT added the enhancement New feature or request label Feb 13, 2024
@Crystal-Spider
Copy link
Member

I understand, I also know what the problem is.
Unfortunately, blame Mojang for this, Flame injects its code directly into the Bow item rather than the Flame enchantment itself (unlike Fire Aspect where the effect is handled by the enchantment).
This means that to make Soul Flame apply to bows I had to change the Bow code.
I'll check how Universal Enchants applies flame to crossbows and I'll see if it's something that should be fixed on my end or on their end.

@Crystal-Spider Crystal-Spider self-assigned this Feb 13, 2024
@Crystal-Spider Crystal-Spider added the question Further information is requested label Feb 13, 2024
@Crystal-Spider
Copy link
Member

Speaking with Universal Enchants author, it's currently not possible to make Soul Flame compatible.
However, he said he will update his mod to allow this, and then I'll have to update mine too.
Until then, this issue can't be solved.

@Crystal-Spider Crystal-Spider added bug Unexpected behavior other mod Not compatible with other mod, needs work from them and removed enhancement New feature or request question Further information is requested labels Feb 16, 2024
@Crystal-Spider Crystal-Spider added no priority Work only if there's nothing else to do pending Waiting for something labels Feb 24, 2024
@Crystal-Spider Crystal-Spider added compatibility Not compatible with other mod, needs work from us and removed bug Unexpected behavior labels Jun 4, 2024
@Crystal-Spider
Copy link
Member

Update: Universal Enchants author told me that its change is ready but not released yet, and that he will notify me when it'll be available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Not compatible with other mod, needs work from us no priority Work only if there's nothing else to do other mod Not compatible with other mod, needs work from them pending Waiting for something
Projects
Status: Pending
Development

No branches or pull requests

2 participants