Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain better the configuration options #39

Closed
Crystal-Spider opened this issue Feb 22, 2024 · 4 comments
Closed

Explain better the configuration options #39

Crystal-Spider opened this issue Feb 22, 2024 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@Crystal-Spider
Copy link
Member

Wiki page: Tweaking enchantments

Describe your suggestion/ask your question:
Explain better all the options for the enchantments builder and fix the configuration options descriptions.

@Crystal-Spider Crystal-Spider added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 22, 2024
@Crystal-Spider Crystal-Spider self-assigned this Feb 22, 2024
@Crystal-Spider
Copy link
Member Author

Three flags change the enchantment discovery:

treasure determines whether you can find the enchantment in the enchanting table.
trades determines whether you can find the enchantment as a villager trade.
discovery determines whether you can find it in the enchanting table and in loots. However, treasure takes precedence.

For example, if you wanted it to behave like Vanilla Mending, you'd enable all three flags. This way it wouldn't be found in the enchanting table (treasure flag takes precedence), but you could still find it in loots and trades.

@Crystal-Spider Crystal-Spider added medium priority Needs to be worked on and removed enhancement New feature or request labels Feb 24, 2024
@Crystal-Spider
Copy link
Member Author

Waiting for #42

@Crystal-Spider Crystal-Spider added this to the 4.0.0.0 milestone May 28, 2024
@Crystal-Spider
Copy link
Member Author

Explained better in the configuration toml file.

@Crystal-Spider
Copy link
Member Author

Explained better in the Javadoc.

@Crystal-Spider Crystal-Spider removed the medium priority Needs to be worked on label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Development

No branches or pull requests

1 participant